Thanks @mbeattie!
Just out of curiousity, what is the downside to running a rediscover before each workflow? Obviously that would add to the time it takes for the workflow to complete, but I can't see any other downside. And, if the customer isn't too worried about the runtime, it may make sense to prevent this issue.
I did just confirm that if I run a workflow twice in a row, it tries to create the same volume name twice (despite the fact that it is supposed to increment the name) unless I force the updates between runs. The workflow(s) I'm using originated from the certified workflows, but have been heavily modified from them. Some of them were modified before I started here by someone who is no longer with the company.
In the Details tab of the workflow, I do have the box checked for "Consider Reserved Elements". After I run the workflow, if I look at "Reservations", it lists the job as successful, but it says "NO" under "Cache Updated." If I wait a few minutes, that eventually changes to "YES".
On the one I just ran, I do see a few error messages similar to the following in the workflow logs:
2017-10-18 10:54:35,390 INFO [com.netapp.wfa.engine.reservations.ReservationsRunnerImpl] (default task-30) Failed to run reservation script for reservation with id '11': Column count doesn't match value count at row 1
This is the code under the "Reservation Script" of the Vol Creation Command. It looks like it's the same as the certified command, but maybe when we modified the command it invalidated something in this code? This reservation script seems like a lot more code than is necessary for just a volume creation:
# Create a new volume
INSERT
INTO
cm_storage.volume
SELECT
NULL AS id,
vs.id AS vserver_id,
ag.id AS aggregate_id,
NULL AS parent_volume_id,
'${VolumeName}' AS name,
'${Size}' AS size_mb,
0 AS used_size_mb,
IF('${SnapshotReservePercentage}' IS NULL || '${SnapshotReservePercentage}'=-1,
'${Size}',
'${Size}'-'${SnapshotReservePercentage}'*'${Size}'/100) AS available_size_mb,
IF('${VolumeType}' IS NULL,
"rw",
'${VolumeType}'), -- type
IF ('${State}'<>'',
'${State}',
'online') AS state,
IF('${JunctionPath}' IS NULL,
CONCAT("/",
'${VolumeName}'),
'${JunctionPath}') AS junction_path,
'${SpaceGuarantee}' AS space_guarantee,
0 AS snapshot_used_mb,
IF('${SnapshotReservePercentage}' IS NULL || '${SnapshotReservePercentage}'=-1,
0,
'${SnapshotReservePercentage}') AS snapshot_reserved_percent,
TRUE AS snapshot_enabled,
'flex' AS style,
'${AutosizeMaxSize}' AS max_autosize_mb,
'64-bit' AS block_type,
'${SecurityStyle}' AS security_style,
'${Deduplication}' AS dedupe_enabled,
'${AutosizeIncrementSize}' AS auto_increment_size_mb,
sp.id AS snapshot_policy_id,
NULL AS export_policy_id,
NULL AS autosize_enabled,
'${Compression}' AS compression,
NULL AS deduplication_space_saved_mb,
NULL AS compression_space_saved_mb,
NULL AS percent_deduplication_space_saved,
NULL AS percent_compression_space_saved,
NULL AS hybrid_cache_eligibility,
NULL AS inode_files_total,
NULL AS inode_files_used,
NULL AS auto_size_mode,
NULL AS sis_last_op_begin_timestamp,
NULL AS sis_last_op_end_timestamp,
NULL AS flexcache_origin_volume,
NULL AS flexcache_min_reserve_mb,
NULL AS constituent_role,
NULL AS is_managed_by_service,
NULL AS storage_class,
NULL AS snap_diff_enabled,
NULL AS max_namespace_constituent_size_mb,
NULL AS max_data_constituent_size_mb,
NULL AS efficiency_policy_id,
qos.id AS qos_policy_group_id,
IF('${Language}' IS NULL,
vs.language,
'${Language}') AS language,
NULL AS data_daily_growth_rate_mb,
NULL AS data_days_until_full,
0 AS auto_delete_enabled,
NULL AS auto_delete_commitment,
NULL AS auto_delete_delete_order,
NULL AS auto_delete_defer_delete,
NULL AS auto_delete_target_free_space,
NULL AS auto_delete_trigger,
NULL AS auto_delete_prefix,
NULL AS auto_delete_destroy_list
FROM
cm_storage.aggregate ag
JOIN
cm_storage.node n
ON ag.name = '${AggregateName}'
AND ag.node_id = n.id
JOIN
cm_storage.vserver vs
ON vs.name = '${VserverName}'
JOIN
cm_storage.cluster cl
ON (
cl.primary_address='${Cluster}'
OR cl.name='${Cluster}'
)
AND vs.cluster_id = cl.id
AND n.cluster_id = cl.id
LEFT JOIN
cm_storage.export_policy ep
ON ep.vserver_id = vs.id
AND ep.name = '${ExportPolicy}'
LEFT JOIN
cm_storage.qos_policy_group qos
ON qos.name = '${PolicyGroupName}'
AND qos.vserver_id = vs.id
AND vs.cluster_id = cl.id
LEFT JOIN
cm_storage.snapshot_policy sp
ON sp.name = CAST( IF('${SnapshotPolicy}' is not null,
'${SnapshotPolicy}',
'default') AS CHAR(255) )
AND sp.vserver_id = vs.id
AND vs.cluster_id = cl.id ;
#If the '${SnapshotPolicy}' input is not specified, set the volume.snapshot_policy_id to the default snapshot policy id associated with the admin vserver
IF '${SnapshotPolicy}' is null THEN UPDATE
cm_storage.volume vol
JOIN
cm_storage.vserver vs
ON vol.name = '${VolumeName}'
AND vs.type = 'admin'
JOIN
cm_storage.cluster cl
ON (
cl.primary_address = '${Cluster}'
OR cl.name = '${Cluster}'
)
AND cl.id = vs.cluster_id
JOIN
cm_storage.snapshot_policy sp
ON sp.cluster_id = cl.id
AND sp.name= 'default'
SET
vol.snapshot_policy_id = sp.id;
END IF;
# change aggregate's used capacity
IF '${SpaceGuarantee}' = 'volume' THEN UPDATE
cm_storage.aggregate ag
JOIN
cm_storage.node n
ON ag.name = '${AggregateName}'
AND ag.node_id = n.id
JOIN
cm_storage.cluster cl
ON (
cl.primary_address='${Cluster}'
OR cl.name='${Cluster}'
)
AND n.cluster_id = cl.id
SET
ag.used_size_mb = ag.used_size_mb + '${Size}',
ag.available_size_mb = ag.available_size_mb - '${Size}'
WHERE
ag.available_size_mb > 0;
END IF;
# change aggregate's volume count
UPDATE
cm_storage.aggregate ag
JOIN
cm_storage.node n
ON ag.name = '${AggregateName}'
AND ag.node_id = n.id
JOIN
cm_storage.cluster cl
ON (
cl.primary_address='${Cluster}'
OR cl.name='${Cluster}'
)
AND n.cluster_id = cl.id
SET
ag.volume_count = ag.volume_count + 1 ;
Reservation Representation:
"Create volume `" + VolumeName + "` of size " + Size + "MB in aggregate `" + AggregateName + "` of cluster `" + Cluster + "` (Storage Virtual Machine `" + VserverName + "`)"
