Netapp-Harvest small feature request

[Nexica]

If a worker is not running,  return code should be diferent to "0"

# /etc/init.d/netapp-harvest status
STATUS          POLLER               SITE
############### #################### ##################
[RUNNING]       netapp-cdot-01   bcn
[RUNNING]       netapp-cdot-02   bcn
[RUNNING]       netapp-ctl-01    bcn
[RUNNING]       netapp-ctl-02    bcn
[RUNNING]       netapp-ctl-03    bcn
[NOT RUNNING]   netapp-ctl-04    bcn
[RUNNING]       netapp-manager   bcn

 

# echo $?
0

[madden · Accepted solution]

Hi @Nexica

I totally agree and will update Harvest for the next release to follow the standard documented here: https://refspecs.linuxfoundation.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.html

Especially if using something like Puppet or Chef accurate return codes are needed.  If you have already fixed and can provide the patch (via private message or here) it is always welcome!

Cheers,
Chris Madden

Storage Architect, NetApp EMEA (and author of Harvest)

Blog: It all begins with data

If this post resolved your issue, please help others by selecting ACCEPT AS SOLUTION or adding a KUDO or both!